Update Unreal SDK to websocket 2.0#4497
Conversation
|
@jdetter I'll work with you on this for the version bump and make sure that is done and reset up once this is ready to merge.
|
|
Overall this LGTM. All the key pieces are there. |
So |
rekhoff
left a comment
There was a problem hiding this comment.
My concerns have been addressed. I have not tested the PR, but this looks good to me.
rekhoff
left a comment
There was a problem hiding this comment.
I only have some minor nits with grammar/phrasing. Otherwise this looks good to me.
docs/docs/00300-resources/00100-how-to/00600-migrating-to-2.0.md
Outdated
Show resolved
Hide resolved
docs/docs/00100-intro/00300-tutorials/00400-unreal-tutorial/00300-part-2.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ryan <r.ekhoff@clockworklabs.io> Signed-off-by: Jason Larabie <jason@clockworklabs.io>
…300-part-2.md Co-authored-by: Ryan <r.ekhoff@clockworklabs.io> Signed-off-by: Jason Larabie <jason@clockworklabs.io>
docs/docs/00100-intro/00300-tutorials/00400-unreal-tutorial/00500-part-4.md
Outdated
Show resolved
Hide resolved
sdks/unreal/src/SpacetimeDbSdk/Source/SpacetimeDbSdk/Public/Connection/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Some minor questions/nits in the docs which is where I did a majority of my thorough pass. The quantity of code changes here makes it quite hard to review via the Github UI so I wasn't able to do a very thorough pass on the code. If a more thorough code review is required we should break any generated code into a separate PR and base that on this PR, otherwise the Github UI is pretty unusable.
I don't have anything that would block this PR from merging but again I didn't do a very thorough pass on the code changes here.
Update: I looked at the tools/upgrade-version/src/main.rs changes and also the generate.rs changes and both of those look good to me.
Description of Changes
API and ABI breaking changes
metadata is invalid instead of continuing past setup issues.
Expected complexity level and risk
3 - A large set of changes to update the websocket/message handling along with heavy codegen changes to handle multi-module support
Testing
Test coverage of the Unreal SDK will need expansion in a future ticket once our issues with flakiness on CI is resolved.
--module-prefixReview Question(s)
spacetime inithave made the tutorial a little confusing with pathing for the Unreal Blackholio tutorial. To fix though we'd have to update all the commands to be more explicit, or update the tutorialspacetime initto use--project-path .to keep pathing simpler, thoughts?